feat(collateral-contract): adds a authorized sender role to block sen… #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ColePBryan
force-pushed
the
23-add-an-allow-list-for-senders-controlled-through-a-governance
branch
2 times, most recently
from
d89491e
to
f6b0f06
Compare
tmigone
approved these changes
Jul 20, 2023
aasseman
approved these changes
Jul 20, 2023
aasseman
force-pushed
the
23-add-an-allow-list-for-senders-controlled-through-a-governance
branch
from
0e4ec7d
to
087773f
Compare
ColePBryan
force-pushed
the
23-add-an-allow-list-for-senders-controlled-through-a-governance
branch
2 times, most recently
from
a439f97
to
4806480
Compare
src/Collateral.sol
Outdated
Comment on lines
15
to
22
| * @dev This contract allows `senders` who are whitelisted to deposit collateral for specific `receivers`, | ||
| * which can later be redeemed using Receipt Aggregate Vouchers (`RAV`) signed | ||
| * by an authorized `signer`. `Senders` can deposit collateral for `receivers`, | ||
| * authorize `signers` to create signed `RAVs`, and withdraw collateral after a | ||
| * set `thawingPeriod` number of seconds. `Receivers` can redeem signed `RAVs` to | ||
| * claim collateral. | ||
| * @notice This contract uses the `TAPVerifier` contract for recovering signer addresses | ||
| * from `RAVs`. | ||
| * from `RAVs`. AccessControlDefaultAdminRules is used for managing sender authorization. |
There was a problem hiding this comment.
Ok, taking those changes and porting them to GIP. Thanks @ColePBryan 👍
…der actions for unauthorized addresses Signed-off-by: Bryan Cole <bryan.cole@semiotic.ai>
…trol changes Signed-off-by: Bryan Cole <bryan.cole@semiotic.ai>
ColePBryan
force-pushed
the
23-add-an-allow-list-for-senders-controlled-through-a-governance
branch
from
4806480
to
7f663fb
Compare
|
Closing as not needed/ won't merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…der actions for unauthorized addresses
NOTE: This should will not be merged until a decision is made regarding senders (gateways) being open-access or whitelisted. The main branch is currently open-access and this branch would add whitelisting instead.