Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(TAP-Verifier): Corrects the name of receipt aggregate voucher str… #49

Merged

Conversation

ColePBryan
Copy link
Contributor

…uct to match type hash and comply with eip 712

eip 712 requires the name in the typehash to exactly match the name of the actual struct.

BREAKING CHANGE:

ReceiptAggregationVoucher struct renamed to ReceiptAggregateVoucher

…uct to match type hash and comply with eip 712

eip 712 requires the name in the typehash to exactly match the name of the actual struct.

BREAKING CHANGE:

ReceiptAggregationVoucher struct renamed to ReceiptAggregateVoucher

Signed-off-by: Bryan Cole <bryan.cole@semiotic.ai>
@ColePBryan ColePBryan self-assigned this Aug 17, 2023
@ColePBryan ColePBryan linked an issue Aug 17, 2023 that may be closed by this pull request
Copy link
Collaborator

@aasseman aasseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ColePBryan ColePBryan merged commit 0cbe980 into main Aug 17, 2023
4 checks passed
@ColePBryan ColePBryan deleted the 44-n-05-signature-does-not-fully-comply-with-eip-712 branch August 17, 2023 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

N-05 Signature Does Not Fully Comply With EIP-712
2 participants