docs(escrow-contract): update inline-docs to detail the expectations … #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of indexers during thaws and redeems provide multiple warnings and notices to ensure indexers are aware of the expected behavior for anything that is thawing or already thawed. Also provide docs to inform indexer that redeem does not revert on low escrow balance and it is their responsibility to check it before calling redeem. Signed-off-by: Bryan Cole <bryan.cole@semiotic.ai>
aasseman
approved these changes
Aug 23, 2023
ColePBryan
deleted the
60-document-thawing-redeeming-in-escrowsol-to-clarify-expectations-of-indexer
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…of indexers during thaws and redeems
provide multiple warnings and notices to ensure indexers are aware of the expected behavior for anything that is thawing or already thawed. Also provide docs to inform indexer that redeem does not revert on low escrow balance and it is their responsibility to check it before calling redeem.