Add unassigned deposits #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: carlos.vdr <carlos.vdr@semiotic.ai>
Signed-off-by: carlos.vdr <carlos.vdr@semiotic.ai>
|
Please help me review this PR, still need to add tests into the local tests. |
pcarranzav
reviewed
Nov 16, 2023
schema.graphql
Outdated
| @@ -37,6 +37,13 @@ type Transaction @entity{ | |||
| escrowAccount: EscrowAccount! | |||
| } | |||
|
|
|||
| type UnnasignedTransaction @entity{ | |||
There was a problem hiding this comment.
Rather than creating this new entity, would it be simpler if you just add an unassignedBalance field in the Sender entity? Or is there a reason why you'd prefer this?
There was a problem hiding this comment.
that does make sense, didnt thought of that thanks!
Signed-off-by: carlos.vdr <carlos.vdr@semiotic.ai>
Signed-off-by: carlos.vdr <carlos.vdr@semiotic.ai>
Signed-off-by: carlos.vdr <carlos.vdr@semiotic.ai>
Signed-off-by: carlos.vdr <carlos.vdr@semiotic.ai>
pcarranzav
approved these changes
Nov 27, 2023
|
Closing this as this changes were discarded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.