Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: listen on 0.0.0.0 instead of localhost #204

Merged
merged 2 commits into from Jan 15, 2024

Conversation

aasseman
Copy link
Collaborator

The previous fix was at wrong place (test code)

@aasseman aasseman added the bug Something isn't working label Jan 11, 2024
@aasseman aasseman self-assigned this Jan 11, 2024
This reverts commit 5099ad1.

Signed-off-by: Alexis Asseman <alexis@semiotic.ai>
Signed-off-by: Alexis Asseman <alexis@semiotic.ai>
Copy link

github-actions bot commented Jan 11, 2024

Pull Request Test Coverage Report for Build 7493532574

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 73.516%

Totals Coverage Status
Change from base Build 7480515696: 0.0%
Covered Lines: 1313
Relevant Lines: 1786

💛 - Coveralls

This comment has been minimized.

1 similar comment
Copy link

🤖 Cargo Audit Report 🤖

(Empty means OK! 👍)

Copy link
Collaborator

@gusinacio gusinacio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aasseman aasseman merged commit 95d8ea6 into main Jan 15, 2024
8 checks passed
@aasseman aasseman deleted the aasseman/fix_listen_address branch January 15, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants