Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update alloy-rs core types monorepo to 0.7.0 #224

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

LNSD
Copy link
Contributor

@LNSD LNSD commented Apr 10, 2024

Recently, a new "major" version of the alloy-rs crates has been released.

As this version is incompatible with the previous one in "semver terms", this PR updates the version to the latest one.

@LNSD LNSD force-pushed the chore-deps-update-alloy-crates branch from bb476d6 to 4194b27 Compare April 10, 2024 14:01
Signed-off-by: Lorenzo Delgado <lorenzo@edgeandnode.com>
@LNSD LNSD force-pushed the chore-deps-update-alloy-crates branch from 4194b27 to 6b989ac Compare April 10, 2024 14:02
Copy link
Collaborator

@gusinacio gusinacio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, could you run cargo build just to update the Cargo.lock file?

@LNSD
Copy link
Contributor Author

LNSD commented Apr 10, 2024

Hey, could you run cargo build just to update the Cargo.lock file?

@gusinacio The Cargo.lock file is not checked into this repository. What's the point of doing that? 🤔

BTW, I ran it locally before opening the PR with the tests, and everything passed on my machine.

@gusinacio
Copy link
Collaborator

@gusinacio The Cargo.lock file is not checked into this repository. What's the point of doing that? 🤔

BTW, I ran it locally before opening the PR with the tests, and everything passed on my machine.

Hey, thanks for the heads up. I'll take a look and fix this on a future pr.

@gusinacio gusinacio self-requested a review April 10, 2024 16:15
Copy link
Collaborator

@gusinacio gusinacio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gusinacio gusinacio merged commit c179dfe into semiotic-ai:main Apr 10, 2024
6 of 8 checks passed
@gusinacio
Copy link
Collaborator

The failing checks are due to permissions of external contributions already being tracked by #193

@LNSD LNSD deleted the chore-deps-update-alloy-crates branch April 10, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants