changed behaviour of default_error_handler

CHANGELOG.md

@@ -1,3 +1,7 @@
+## 2.4.0
+
+* changed default behavior of error_handler: now it raises an exception
+
 ## 2.3.3
 
 * added `broqer.Timer` class and rewrite `op.Throttle` to use that class

broqer/error_handler.py

@@ -1,13 +1,12 @@
 """ Implementing DefaultErrorHandler. Object default_error_handler is used
 as global object to register a callbacks for exceptions in asynchronous
 operators, """
-import traceback
 
 
 def _default_error_callback(exc_type, exc_value, exc_traceback):
     """ Default error callback is printing traceback of the exception
     """
-    traceback.print_exception(exc_type, exc_value, exc_traceback)
+    raise exc_value.with_traceback(exc_traceback)
 
 
 class DefaultErrorHandler:

broqer/publisher.py

@@ -1,8 +1,9 @@
 """ Implementing Publisher """
+import sys
 from typing import (TYPE_CHECKING, TypeVar, Type, Tuple, Callable, Optional,
                     overload)
 
-from broqer import NONE, Disposable
+from broqer import NONE, Disposable, default_error_handler
 import broqer
 
 if TYPE_CHECKING:
@@ -141,7 +142,10 @@ def notify(self, value: TValue) -> None:
         """
         self._state = value
         for subscriber in tuple(self._subscriptions):
-            subscriber.emit(value, who=self)
+            try:
+                subscriber.emit(value, who=self)
+            except Exception:  # pylint: disable=broad-except
+                default_error_handler(*sys.exc_info())
 
     def reset_state(self) -> None:
         """ Resets the state. Calling this method will not trigger a
@@ -150,7 +154,10 @@ def reset_state(self) -> None:
         """
         self._state = NONE
         for subscriber in tuple(self._subscriptions):
-            subscriber.reset_state()
+            try:
+                subscriber.reset_state()
+            except Exception:  # pylint: disable=broad-except
+                default_error_handler(*sys.exc_info())
 
     @property
     def subscriptions(self) -> Tuple['Subscriber', ...]:

tests/test_error_handler.py

@@ -12,15 +12,8 @@ def test_default(capsys):
     except:
         exc = sys.exc_info()
 
-    default_error_handler(*exc)
-
-    captured = capsys.readouterr()
-
-    assert captured.err.startswith('Traceback (most recent call last):')
-    assert 'ZeroDivisionError: division by zero' in captured.err
-    assert __file__ in captured.err
-
-    assert captured.out == ''
+    with pytest.raises(ZeroDivisionError):
+        default_error_handler(*exc)
 
 
 def test_set_errorhandler(capsys):
@@ -44,7 +37,5 @@ def test_set_errorhandler(capsys):
     # reset
     default_error_handler.reset()
 
-    default_error_handler(*exc)
-
-    captured = capsys.readouterr()
-    assert captured.err.startswith('Traceback (most recent call last):')
+    with pytest.raises(ZeroDivisionError):
+        default_error_handler(*exc)