don't call Publisher.register_on_subscription() when initially no sub…

…scriber is available
semiversus · Dec 3, 2020 · 9beb265 · 9beb265
1 parent 155573b
commit 9beb265
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/broqer/publisher.py b/broqer/publisher.py
@@ -182,7 +182,8 @@ def register_on_subscription_callback(self,
             raise ValueError('A callback is already registered')
 
         self._on_subscription_cb = callback
-        callback(bool(self._subscriptions))
+        if self._subscriptions:
+            callback(True)
 
     def __await__(self):
         """ Makes publisher awaitable. When publisher has a state it will

diff --git a/tests/test_core_publisher.py b/tests/test_core_publisher.py
@@ -133,10 +133,6 @@ def test_subscription_callback():
     p = Publisher()
     p.register_on_subscription_callback(m)
 
-    # callback should be immediatly called with `False` when no subscriber is available
-    m.assert_called_once_with(False)
-    m.reset_mock()
-
     # callback should be called on first subscription (with True as argument)
     d1 = p.subscribe(Sink())
     m.assert_called_once_with(True)