-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GrpcChannel tests not working anymore #172
Comments
Another thing I discovered is that the CI does not automatically run the tests with the flag QT_PROTOBUF_NATIVE_GRPC_CHANNEL. I don't know how the CI works, so I'm only reporting it to you |
Hi @rapgenic , I added public compile definition to QtGrpc, that should work. Let me check first. I didn't enable these tests on CI because at some point travis start exit by timeout. For sanity check I probably will omit QT_PROTOBUF_NATIVE_GRPC_CHANNEL for now. But for master branch will enable it after some timing tests. Thanks! |
@rapgenic I checked locally seems QT_PROTOBUF_NATIVE_GRPC_CHANNEL works as expected and I see tests passed. Did you enable QT_PROTOBUF_NATIVE_GRPC_CHANNEL in your build setup? Keep in mind that I made this CMake property cached and it might not be enabled without reconfiguration. |
It seems that my system is the problem, even though I cannot identify what it is... I'll try to investigate a bit more but right now I have no clue. |
I found something quite strange using cmake the value of QT_PROTOBUF_NATIVE_GRPC_CHANNEL changed when building tests, because the How is it possible? Is there any form of caching outside the local build folder? |
Ok I think I might have found the problem. I observed that deleting the Qtprotobuf actually uses this function to export itself as a package, and I think that after building it in another place, it registered itself as the qtprotobuf package, so when building the tests in another location, |
Probably I should add if(TARGET ...) check before find_package in tests and examples. |
- Add check for local targets for examples and tests - Make microjson build explicitly static Fixes: #172
- Add check for local targets for examples and tests - Make microjson build explicitly static Fixes: #172
- Add check for local targets for examples and tests - Rename test helper file - Refactor test helper functions and add extra helpers for examples - Replace global variable that hold protoparser.go by Generator target property Fixes: #172
- Add check for local targets for examples and tests - Rename test helper file - Refactor test helper functions and add extra helpers for examples - Replace global variable that hold protoparser.go by Generator target property Fixes: #172
- Add check for local targets for examples and tests - Rename test helper file - Refactor test helper functions and add extra helpers for examples - Replace global variable that hold protoparser.go by Generator target property Fixes: #172
- Add check for local targets for examples and tests - Rename test helper file - Refactor test helper functions and add extra helpers for examples - Replace global variable that hold protoparser.go by Generator target property Fixes: #172
- Add check for local targets for examples and tests - Rename test helper file - Refactor test helper functions and add extra helpers for examples - Replace global variable that hold protoparser.go by Generator target property Fixes: #172
- Add check for local targets for examples and tests - Rename test helper file - Refactor test helper functions and add extra helpers for examples - Replace global variable that hold protoparser.go by Generator target property Fixes: #172
- Add check for local targets for examples and tests - Rename test helper file - Refactor test helper functions and add extra helpers for examples - Replace global variable that hold protoparser.go by Generator target property Fixes: #172
- Add check for local targets for examples and tests - Rename test helper file - Refactor test helper functions and add extra helpers for examples - Replace global variable that hold protoparser.go by Generator target property Fixes: #172
- Add check for local targets for examples and tests - Rename test helper file - Refactor test helper functions and add extra helpers for examples - Replace global variable that hold protoparser.go by Generator target property Fixes: #172
- Add check for local targets for examples and tests - Rename test helper file - Refactor test helper functions and add extra helpers for examples - Replace global variable that hold protoparser.go by Generator target property Fixes: #172
- Add check for local targets for examples and tests - Rename test helper file - Refactor test helper functions and add extra helpers for examples - Replace global variable that hold protoparser.go by Generator target property Fixes: #172
- Add check for local targets for examples and tests - Rename test helper file - Refactor test helper functions and add extra helpers for examples - Replace global variable that hold protoparser.go by Generator target property - Enable well known types for windows - Update CI rules for windows Fixes: #172, #183, #12
- Add check for local targets for examples and tests - Rename test helper file - Refactor test helper functions and add extra helpers for examples - Replace global variable that hold protoparser.go by Generator target property - Enable well known types for windows - Update CI rules for windows Fixes: #172, #183, #12
Hi @semlanik,
while testing the new commits I noticed that the tests I wrote aren't working anymore and I suspect the cause is the removal of the following lines from the
tests/test_grpc/CMakeLists.txt
That happened on commit: facaba6
The text was updated successfully, but these errors were encountered: