Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake script problems #238

Closed
lubagov opened this issue Aug 20, 2021 · 1 comment · Fixed by #241
Closed

CMake script problems #238

lubagov opened this issue Aug 20, 2021 · 1 comment · Fixed by #241
Assignees
@semlanik
Labels
bug Something isn't working grpc QtGrpc related issues
Projects
Qt Protobuf
Milestone
v0.7.0

Comments

@lubagov
Copy link

lubagov commented Aug 20, 2021

Describe the bug
If the QT_PROTOBUF_NATIVE_GRPC_CHANNEL option is enabled, that is, only 2 header files, after installing qgrpcchannel.h and QGrpcChannel, other header files from the QtProtobufGrpc directory are not included in the installation. I'm not very good at CMake scripts, but it seems that the qt_protobuf_internal_extend_target function, instead of adding new ones, overwrites the values and the old ones are deleted.

To Reproduce
set -DQT_PROTOBUF_NATIVE_GRPC_CHANNEL=ON in CMake args.

Environment:
Ubuntu 18.04, CMake 3.18.4
@lubagov lubagov added the bug Something isn't working label Aug 20, 2021
@semlanik semlanik added this to ToDo in Qt Protobuf via automation Aug 22, 2021
@semlanik semlanik added this to the v0.7.0 milestone Aug 22, 2021
@semlanik
Copy link
Owner

It's definetly a bug, and I already have a fix candidate, but meanwhile, I found out that there is AUTOMOC issue that blocks me from submitting a fix.

@semlanik semlanik added the grpc QtGrpc related issues label Aug 23, 2021
semlanik added a commit that referenced this issue Aug 24, 2021
@semlanik
Fix missing header files when extending targets
4b1c3d5 
- Move auto generator directives to the top-level
  CMakeLists.txt.
- Use APPEND property when adding PUBLIC_HEADER
  to the target.

Fixes #238
@semlanik semlanik mentioned this issue Aug 24, 2021
Merged
semlanik added a commit that referenced this issue Aug 24, 2021
@semlanik
Fix missing header files when extending targets
044ede7 
- Move auto generator directives to the top-level
  CMakeLists.txt.
- Use APPEND property when adding PUBLIC_HEADER
  to the target.

Fixes #238
semlanik added a commit that referenced this issue Aug 25, 2021
@semlanik
Fix missing header files when extending targets
69abe8c 
- Move auto generator directives to the top-level
  CMakeLists.txt.
- Use APPEND property when adding PUBLIC_HEADER
  to the target.

Fixes #238
Qt Protobuf automation moved this from ToDo to Done Aug 25, 2021
semlanik added a commit that referenced this issue Aug 25, 2021
@semlanik
Fix missing header files when extending targets
7eeb291 
- Move auto generator directives to the top-level
  CMakeLists.txt.
- Use APPEND property when adding PUBLIC_HEADER
  to the target.

Fixes #238
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@semlanik semlanik

Labels
bug Something isn't working grpc QtGrpc related issues
Projects
Qt Protobuf
  
Done
Milestone
v0.7.0
Development

Successfully merging a pull request may close this issue.

Fix missing header files when extending targets semlanik/qtprotobuf
2 participants
@semlanik @lubagov