Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VRM selection is imo suboptimal. #35

Closed
morphles opened this issue Dec 5, 2023 · 6 comments
Closed

VRM selection is imo suboptimal. #35

morphles opened this issue Dec 5, 2023 · 6 comments

Comments

@morphles
Copy link
Contributor

morphles commented Dec 5, 2023

image Admittedly I got somewhat overboard with doenloading vrms, but oh well. Thing is I have no good way to generate previes, and as it's showing it's quite not great. There are couple more issues, one that I'll probably get to sometime maybe, is when new char or anim is loaded char gets "reset", I mean position/orientation/zoom, which I find mildly annoying. But another thing which imo is worse, is that damn menu is covering my view, and also blurring so I can't easily see what I'm selecting/flipping through. So IMO when choosing char, it should not be centered and blurred, to allow to easily cycle and see characters.
@kasumi-1
Copy link
Contributor

kasumi-1 commented Dec 5, 2023

For generating preview, I am not sure what best solution is yet. One option I considered was making a script that used puppeteer to render a vrm and output an image, but maybe there is better way to do it.

For showing the vrms in here, I think we could use something like whats done in the /import page which shows preview using the VrmDemo component.

@morphles
Copy link
Contributor Author

morphles commented Dec 5, 2023

puppeteer is overkill :), and also added dependency. At least for me model loads fast enough just let me flick through them quickly and it ill be ok (well still have to be able to go to the model I know too).

@snowyu
Copy link
Contributor

snowyu commented Dec 14, 2023

Try the node-canvas-webgl to prepare the preivew image.

@kasumi-1
Copy link
Contributor

The same issue for freezing vrm context referenced in #56 needs to be resolved for a preview image to work here.

@Vorlent
Copy link

Vorlent commented Mar 4, 2024

If this is just about creating a thumbnail, then the simplest solution would be to just load the VRM model (it is already loaded in the Character creator) and then use the screen capture API to create an initial thumbnail. It doesn't have to be good, just recognizable.

@slowsynapse
Copy link
Collaborator

This has been solved with vrm load save.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants