enhancement-implemented

[agrim0312]

changed - Link to CustomLink in ./common.tsx due to conflict of same names

Screencast.from.17-12-23.05.04.10.PM.IST.webm

however, did not delete the share page file

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
amica	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 17, 2023 0:53am

[agrim0312]

fixed #52

[kasumi-1]

Hi @agrim0312 thank you. However, can't merge yet as it looks like this broke the build. You can check locally by running npm run build to run the typechecker.

[agrim0312]

sure

[agrim0312]

@kasumi-1 fixed the build You can review it now

[kasumi-1]

This freezes the character when closed. Also, there are some whitespace and indent issues - I fixed these in https://github.com/semperai/amica/tree/sharePage-2-modal-component but I am unsure of cause of freezing on close.

[agrim0312]

hi @kasumi-1, I am not able to solve the issue however I have narrowed it down. As soon as VrmDemo gets loaded in the shareModal.tsx file the character freezes. I tried rendering modal without VrmDemo and it did'nt freeze and worked fine.

here is the VrmDemo div. Please guide me so that I can fix the issue.

[slowsynapse]

I think this PR is resolved with the load/save VRM feature added. Will double check in future.