Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Never Shorten Long Descriptions doesn't work in some cases #1022

Closed
wpsmort opened this issue Aug 3, 2017 · 4 comments
Closed

Never Shorten Long Descriptions doesn't work in some cases #1022

wpsmort opened this issue Aug 3, 2017 · 4 comments
Labels
Bug
Milestone
2.4

Comments

@wpsmort
Copy link

wpsmort commented Aug 3, 2017

Auto generated meta descriptions are still being shortened even when you enable the Never Shorten Long Descriptions option and the Use Content For Autogenerated Descriptions options together under Advanced Settings.

If you don't enable the Use Content For Autogenerated Descriptions option then auto generated meta descriptions are not shortened.

I tested back through the versions and found that this has never worked.
@wpsmort wpsmort added the Bug label Aug 3, 2017
@michaeltorbert michaeltorbert added this to the 2.3.16 milestone Aug 7, 2017
@amostajo amostajo self-assigned this Aug 12, 2017
amostajo added a commit to amostajo/all-in-one-seo-pack that referenced this issue Aug 12, 2017
@amostajo
awesomemotive#1022 Enable Never Shorten Long Descriptions
57a2135 
Make existing setting `Never Shorten Long Descriptions` functional.
@amostajo
Copy link
Contributor

Ready for testing. PR1083

@amostajo amostajo mentioned this issue Aug 14, 2017
Closed
@wpsmort wpsmort self-assigned this Aug 14, 2017
@wpsmort
Copy link
Author

wpsmort commented Aug 14, 2017

This is tested and is good. PR #1083 is ready for code review.

@wpsmort wpsmort assigned michaeltorbert and unassigned amostajo and wpsmort Aug 14, 2017
@wpsmort wpsmort modified the milestones: 2.3.16, 2.3.17 Aug 22, 2017
@amostajo
Copy link
Contributor

@wpsmort changes made for #951 fixes this issue as well. Please re-test this using PR 1031
#1031

@michaeltorbert michaeltorbert mentioned this issue Aug 24, 2017
Merged
@michaeltorbert michaeltorbert assigned wpsmort and unassigned amostajo Aug 24, 2017
@wpsmort wpsmort modified the milestones: 2.3.17, 2.4 Sep 5, 2017
@wpsmort wpsmort modified the milestones: 2.4, 2.3.17 Sep 5, 2017
@wpsmort
Copy link
Author

wpsmort commented Sep 5, 2017

PR #1031 is tested and is good.

Enabling the Never Shorten Long Descriptions option now works regardless of whether you are using the excerpt or the content as the auto generated meta description.

@wpsmort wpsmort removed their assignment Sep 5, 2017
@michaeltorbert michaeltorbert removed their assignment Sep 6, 2017
michaeltorbert pushed a commit that referenced this issue Sep 6, 2017
@amostajo @michaeltorbert
#951 Fixes wrong string counts due to HTML entities and #1022 never s…
cce3a39 
…horten long description

#951 Fixes wrong string counts due to HTML entities and #1022 never shorten long description

* remove category capitalization from get_tax_name function #530

* remove tag and search capitalization of titles #560

* #951 Fixes wrong string counts due to HTML entities

Fixes wrong title/description length counts that were being generated
due to HTML entities not being decoded.
#951 Fixes wrong string counts due to HTML entities and #1022 never shorten long description

* #951 Refactored truncation execution order

Refactored the way the description was being truncated or cropped.
@michaeltorbert michaeltorbert changed the title Never Shorten Long Descriptions no longer works Never Shorten Long Descriptions doesn't work in some cases Sep 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
2.4
Development

No branches or pull requests
3 participants
@amostajo @michaeltorbert @wpsmort