Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XML Sitemap - Add filter to disable images in sitemap #1192

Closed
wpsmort opened this issue Sep 28, 2017 · 3 comments
Closed

XML Sitemap - Add filter to disable images in sitemap #1192

wpsmort opened this issue Sep 28, 2017 · 3 comments
Labels
API
Milestone
2.4

Comments

@wpsmort
Copy link

wpsmort commented Sep 28, 2017

As discussed today, we should add a filter so that users can disable the images in XML Sitemap we added in Issue #386.
@wpsmort wpsmort added the API label Sep 28, 2017
@wpsmort wpsmort added this to the 2.4 milestone Sep 28, 2017
@wpsmort wpsmort mentioned this issue Sep 28, 2017
Closed
@michaeltorbert
Copy link
Contributor

The filter is aioseo_include_images_in_sitemap, just __return_false on it.

michaeltorbert added a commit that referenced this issue Sep 28, 2017
@michaeltorbert
add filter to disable images in sitemap #1192
1552f66
@michaeltorbert michaeltorbert mentioned this issue Sep 28, 2017
Merged
@michaeltorbert michaeltorbert removed their assignment Sep 28, 2017
michaeltorbert added a commit that referenced this issue Sep 28, 2017
@michaeltorbert
add filter to disable images in sitemap #1192 with better array
89bfaed
@wpsmort
Copy link
Author

wpsmort commented Sep 28, 2017

@michaeltorbert I tested PR #1194 and got two errors in the debug log which resulted in a broken sitemap:

PHP Warning: Missing argument 2 for apply_filters(), called in /wp-content/plugins/all-in-one-seo-pack-issue-1192/modules/aioseop_sitemap.php on line 2663 and defined in /wp-includes/plugin.php on line 176

PHP Notice: Undefined variable: value in /wp-includes/plugin.php on line 191

michaeltorbert added a commit that referenced this issue Sep 28, 2017
@michaeltorbert
default to true #1192
0841386
@michaeltorbert
Copy link
Contributor

Fixed.

michaeltorbert added a commit that referenced this issue Sep 28, 2017
@michaeltorbert
Filter should remove images from terms as well #1192
21f63b5
michaeltorbert added a commit that referenced this issue Sep 28, 2017
@michaeltorbert
add filter to disable images in sitemap
7dc3e7c 
* add filter to disable images in sitemap #1192

* add filter to disable images in sitemap #1192 with better array

* default to true #1192

* commas go inside parentheses

* Filter should remove images from terms as well #1192
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API
Projects
None yet
Milestone
2.4
Development

No branches or pull requests
2 participants
@michaeltorbert @wpsmort