This repository has been archived by the owner on Nov 9, 2017. It is now read-only.
Update project #145
Merged
Update project #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was experiencing errors running the common test suite with Chrome due to the fact that the code was attempting to reference page elements before the page was fully loaded when using click actions on links to cause a new page to load.
Also includes what appears to be more idiomatic setup of the PhantomJSDriver class.
As a library, clj-webdriver should not be concerned with magically loading configuration from the classpath. The library should be refactored to allow users to pass in values they need, and to let them handle configuration as they see fit.
Adds a test selector to avoid running these tests when those manual setup steps have not been run (they're excluded from the default `lein test` run).
Also get to remove `lein2` as now you have to specify `lein1`. Nice to see forward progress *and* even nicer that Travis-CI kept `lein2` around for those of us who haven't updated in a long time.
After Google Form results come in, will adjust based on feedback.
Since Chrome's web driver is not supported by default on Travis CI.
More of the test suite can be run on Travis CI with further Travis configuration effort on my part. For now, this will cover a good swath of the test suite.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes:
*properties*)The only code in clj-webdriver relying on
*properties*was some fallback logic around loading plugins for a Firefox profile. The function using it has the same signature; this simply removes the fallback to look up things in*properties*that would have been read in from one of several possible configuration files at project load time. I've removed it because I feel it's the job of applications, not libraries, to decide when and how configuration should be loaded.