This repository has been archived by the owner. It is now read-only.

Expose webdriver wait functionality #5

Merged
merged 1 commit into from Aug 20, 2011

Conversation

2 participants
@xeqi
Contributor

xeqi commented Aug 19, 2011

Create wait-until and implicitly-wait functions for the driver.

Not all functionality is exposed. I imagine testing something like sleep in miliseconds would be ugly, though perhaps a mock would work since its calling a java object.

Expose webdriver wait functionality
Use seconds for implicitly-wait for consistency with wait-until.
@semperos

This comment has been minimized.

Show comment
Hide comment
@semperos

semperos Aug 19, 2011

Owner

I've been reviewing all the "wait" functionality provided by WebDriver. For WebDriverWait, I think we should support the three-member constructor at a minimum, which allows setting both a timeout and an interval for attempts. I'm not convinced that the five-member constructor adds much value, but I'm open to discussion on that point.

Owner

semperos commented Aug 19, 2011

I've been reviewing all the "wait" functionality provided by WebDriver. For WebDriverWait, I think we should support the three-member constructor at a minimum, which allows setting both a timeout and an interval for attempts. I'm not convinced that the five-member constructor adds much value, but I'm open to discussion on that point.

@semperos semperos merged commit f130364 into semperos:master Aug 20, 2011

@semperos

This comment has been minimized.

Show comment
Hide comment
@semperos

semperos Aug 20, 2011

Owner

I created conflicts with some subsequent edits before merging this request. Thank you very much for adding this functionality and for adding tests for it. Merged.

Owner

semperos commented Aug 20, 2011

I created conflicts with some subsequent edits before merging this request. Thank you very much for adding this functionality and for adding tests for it. Merged.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.