This repository has been archived by the owner. It is now read-only.

Fix for npe in taxi-api. #90

Closed
wants to merge 1 commit into
from

Conversation

2 participants

bonega commented Dec 22, 2012

Most of the taxi element-functions will return nil if the element is missing.
Operations ex. click will return true upon completion.
"elements" return an empty vector if there are no matches.

Hopefully fixes https://github.com/semperos/clj-webdriver/issues/85

Fix for npe in taxi-api.
Most of the taxi element-functions will return nil if the element is missing.
Operations ex. click will return true upon completion.
"elements" return an empty vector if there are no matches.
Owner

semperos commented Dec 25, 2012

This is quite the pull request. Thank you!!

I'm going to take a little time to review this. The idea of #85 was not only to fix this for the Taxi API, but more importantly for the Core API on which everything else is based. I'll take a look at how this would integrate with that approach and hopefully merge this in.

Better style here would be:

(is (nil? (element missing)))

This applies to all uses of (= (nil ...)) below as well.

Owner

bonega replied Dec 25, 2012

Quite right.
As for now I will wait for more feedback from you before I push anything.

bonega commented Jan 17, 2013

Are there anything I can do to help?

Owner

semperos commented Jan 17, 2013

Sorry, my family and I moved recently and it's just been a stressful time getting settled down again.

I will try to get the entire null-handling in clj-webdriver fixed before the end of January. As I mentioned, it needs to be solved at the bottom-most level of the API.

Owner

semperos commented Feb 10, 2013

I've looked at your pull request in more detail. In light of recent conversation over in Issue #85, which has to do with how Clojure core itself will be changing, I don't think this approach will quite fit. I'll keep this issue open until I close #85 in case it is applicable.

Owner

semperos commented Feb 28, 2013

This and #85 fixed with release 0.6.0-beta3

@semperos semperos closed this Feb 28, 2013

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.