[notice] removed critical notification label from notice with warning…

… theme
semrush · Jun 27, 2024 · 229ba89 · 229ba89
1 parent 7f82e95
commit 229ba89
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/semcore/notice/CHANGELOG.md b/semcore/notice/CHANGELOG.md
@@ -2,6 +2,12 @@
 
 CHANGELOG.md standards are inspired by [keepachangelog.com](https://keepachangelog.com/en/1.0.0/).
 
+## [5.35.1] - 2024-06-27
+
+### Fixed
+
+- Notice only with `danger` theme has aria-label "Critical Notification" (`warning` theme gets "Notification" as all other themes).
+
 ## [5.35.0] - 2024-06-19
 
 ### Changed

diff --git a/semcore/notice/src/Notice.jsx b/semcore/notice/src/Notice.jsx
@@ -76,7 +76,7 @@ class RootNotice extends Component {
         backgroundColor={color}
         role='region'
         aria-live={ariaLive}
-        aria-label={getI18nText(isAssertive ? 'criticalNotification' : 'notification')}
+        aria-label={getI18nText(theme === 'danger' ? 'criticalNotification' : 'notification')}
       >
         <Children />
       </SNotice>,