[86byygdea][popper] fixed that switching popper trigger was causing a…

… glitch during the close animation
semrush · May 27, 2024 · e181d84 · e181d84
1 parent bcef316
commit e181d84
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/semcore/popper/CHANGELOG.md b/semcore/popper/CHANGELOG.md
@@ -2,6 +2,12 @@
 
 CHANGELOG.md standards are inspired by [keepachangelog.com](https://keepachangelog.com/en/1.0.0/).
 
+## [5.35.3] - 2024-05-27
+
+### Fixed
+
+- Switching popper trigger was causing a glitch during the close animation.
+
 ## [5.35.2] - 2024-05-27
 
 ### Fixed

diff --git a/semcore/popper/src/Popper.jsx b/semcore/popper/src/Popper.jsx
@@ -222,8 +222,10 @@ class Popper extends Component {
     if (!this.triggerRef.current || !this.popperRef.current) return;
     if (this.asProps.__disablePopper) return;
 
+    const lastPopperReferenceMounted = Boolean(this.lastPopperReference?.parentElement);
+
     this.popper.current = createPopper(
-      this.lastPopperReference ?? this.triggerRef.current,
+      lastPopperReferenceMounted ? this.lastPopperReference : this.triggerRef.current,
       this.popperRef.current,
       this.getPopperOptions(),
     );