New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[website] update TabLine and TabPanel examples and a11y guides #1324
Conversation
Signed-off-by: Julia Mnizhek <77798437+j-mnizhek@users.noreply.github.com>
Signed-off-by: Julia Mnizhek <77798437+j-mnizhek@users.noreply.github.com>
Signed-off-by: Julia Mnizhek <77798437+j-mnizhek@users.noreply.github.com>
Signed-off-by: Julia Mnizhek <77798437+j-mnizhek@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd replace this:
By default, the component switches content automatically when switching tabs.
With something like this:
By default, tabs are switched automatically when selected.
Also, do we want to make showing tooltips obligatory for truncated tab names? If yes, then maybe we should remove the tip about showing the tooltip and instead implement this behaviour out of the box.
BTW, thanks for nice examples! :3
Signed-off-by: Julia Mnizhek <77798437+j-mnizhek@users.noreply.github.com>
Added small change from #1340 to example with disabled tab. |
Moved these changes to #1368 |
Motivation and Context
We need to update:
How has this been tested?
Manually.
Types of changes
Checklist:
CHANGELOG.md
file with planned publish date.