Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[website] update TabLine and TabPanel examples and a11y guides #1324

Closed
wants to merge 10 commits into from

Conversation

j-mnizhek
Copy link
Contributor

Motivation and Context

We need to update:

  • examples for TabLine and TabPanel, add tabpanels with content to all of them
  • update documentation they have on accessibility

How has this been tested?

Manually.

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Nice improve.

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly or it's not required.
  • Unit tests are not broken.
  • I have added changelog note to corresponding CHANGELOG.md file with planned publish date.
  • I have added new unit tests on added of fixed functionality.

j-mnizhek and others added 6 commits April 23, 2024 19:57
Signed-off-by: Julia Mnizhek <77798437+j-mnizhek@users.noreply.github.com>
Signed-off-by: Julia Mnizhek <77798437+j-mnizhek@users.noreply.github.com>
Signed-off-by: Julia Mnizhek <77798437+j-mnizhek@users.noreply.github.com>
Signed-off-by: Julia Mnizhek <77798437+j-mnizhek@users.noreply.github.com>
Copy link
Contributor

@sheila-semrush sheila-semrush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd replace this:

By default, the component switches content automatically when switching tabs.

With something like this:

By default, tabs are switched automatically when selected.

Also, do we want to make showing tooltips obligatory for truncated tab names? If yes, then maybe we should remove the tip about showing the tooltip and instead implement this behaviour out of the box.

BTW, thanks for nice examples! :3

@j-mnizhek
Copy link
Contributor Author

Added small change from #1340 to example with disabled tab.

@j-mnizhek
Copy link
Contributor Author

Moved these changes to #1368

@j-mnizhek j-mnizhek closed this May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants