Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[86bzbmjk4][accordion] accordion a11y improvements #1468

Merged
merged 8 commits into from
Jul 5, 2024

Conversation

ilyabrower
Copy link
Contributor

@ilyabrower ilyabrower commented Jun 26, 2024

Motivation and Context

I've changed order of html elements: now it is h3->button instead of button->h3.
Also I've fixed examples:

  • removed button in button
  • fixed example with custom styles

How has this been tested?

Manually

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Nice improve.

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly or it's not required.
  • Unit tests are not broken.
  • I have added changelog note to corresponding CHANGELOG.md file with planned publish date.
  • I have added new unit tests on added of fixed functionality.

Copy link
Contributor

@j-mnizhek j-mnizhek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall!

Waiting only for some small changes I've mentioned in the inner discussion.

@ilyabrower ilyabrower merged commit abb1ecc into master Jul 5, 2024
9 checks passed
@ilyabrower ilyabrower deleted the feature/accordion_a11y branch July 5, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants