Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Autosuggest a11y tab update #1513

Merged
merged 2 commits into from
Jul 12, 2024
Merged

Conversation

sheila-semrush
Copy link
Contributor

Motivation and Context

  1. Fixed the keyboard behavior description.
  2. Removed the radio/checkbox reference, as it seems it's unnecessary here.
  3. Instead added a link to the Select guide.
  4. Removed the link to "a11y style guide", because it's about other type of select, doesn't seem relevant to autosuggest.
  5. Removed the duplicate of the link to the "popper keyboard control" guide.

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Nice improve.

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly or it's not required.
  • Unit tests are not broken.
  • I have added changelog note to corresponding CHANGELOG.md file with planned publish date.
  • I have added new unit tests on added of fixed functionality.

@sheila-semrush sheila-semrush merged commit dd721ad into master Jul 12, 2024
9 checks passed
@sheila-semrush sheila-semrush deleted the update/autosuggest-a11y-docs branch July 12, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants