Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I'm getting a KeyError: 'serial_settings' from stream_handler.py when trying to use a socket as gnss source. Approx line 124 but I may have added some debug prints. #119

Closed
semuadmin opened this issue Feb 28, 2024 · 0 comments · Fixed by #121
Closed

I'm getting a KeyError: 'serial_settings' from stream_handler.py when trying to use a socket as gnss source. Approx line 124 but I may have added some debug prints. #119

semuadmin opened this issue Feb 28, 2024 · 0 comments · Fixed by #121
Assignees
@semuadmin
Labels
bug Something isn't working

Comments

@semuadmin
Copy link
Contributor

I'm getting a KeyError: 'serial_settings' from stream_handler.py when trying to use a socket as gnss source. Approx line 124 but I may have added some debug prints.

The problem seems to be that the access of settings["serial_settings"] has been moved from within the CONNECTED-specific code up a few lines. I'm guessing that when conntype is CONNECTED_SOCKET, settings doesn't have any "serial_settings".

Looks like it happened in 42e2ae0 "Merge branch 'ubx_simulation' into RC-1.4.10 "

Originally posted by @divenal in #118
@semuadmin semuadmin self-assigned this Feb 28, 2024
@semuadmin semuadmin added the bug Something isn't working label Feb 28, 2024
semuadmin added a commit that referenced this issue Feb 28, 2024
@semuadmin
fix KeyError Fixes I'm getting a KeyError: 'serial_settings' from str…
0ba640e 
…eam_handler.py when trying to use a socket as gnss source. Approx line 124 but I may have added some debug prints. #119
@semuadmin semuadmin mentioned this issue Feb 28, 2024
Merged
12 tasks
@semuadmin semuadmin added this to the 1.4.12 milestone Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@semuadmin semuadmin

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rc 1.4.12 semuconsulting/PyGPSClient
1 participant
@semuadmin