Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle UBX-NAV-PL messages #70

Merged
merged 1 commit into from
May 5, 2022
Merged

Conversation

ArrEssJay
Copy link
Contributor

Description

Handle NAV-PL messages. These were not being parsed, causing an exception to be raised in the parser when present in a stream.

This exception causes a stall of PyGPSClient when attempting to parse a live stream from a TCP socket.

This change does not address the exception handling.

Reference: u-blox F9 HPG 1.32 - Interface Description

Added parser and sample message test case.
Log file containing NAV-PL messages

Testing

Added test case in test_parse.py (message generated by an F9P rx.)

Checklist:

  • [*] My code follows the style guidelines of this project (see CONTRIBUTING.MD).
  • [*] I have performed a self-review of my own code.
  • [*] (if appropriate) I have cited my u-blox documentation source(s).
  • [-] I have commented my code, particularly in hard-to-understand areas.
  • [-] I have made corresponding changes to the documentation.
  • [*] (if appropriate) I have added test cases to the tests/test_*.py unittest suite to maintain >= 99% code coverage.
  • [*] I have tested my code against the full tests/test_*.py unittest suite.
  • [*] My changes generate no new warnings.
  • [-] Any dependent changes have been merged and published in downstream modules.
  • [*] I understand and acknowledge that the code will be published under a BSD 3-Clause license.

Copy link
Contributor

@semuadmin semuadmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ArrEssJay

PR very much appreciated. I think NAV-PL is new to HPG 1.30.

Code is fine but could I request a couple of very small and pedantic changes for consistency:

  1. rename version to msgversion as per the written specification and to avoid any confusion with the pyubx2.version property.
  2. move the NAV-PL message definition in ubxtypes_get.py to after NAV-ORB rather than before it, to keep the definitions in ascending alphabetical order.

Many thanks

@semuadmin
Copy link
Contributor

FYI I'll improve the socket exception handling in PyGPSClient in the next release to address semuconsulting/PyGPSClient#22

@semuadmin semuadmin dismissed their stale review May 5, 2022 06:07

can make changes myself

@semuadmin semuadmin merged commit eeb4f3e into semuconsulting:master May 5, 2022
@semuadmin semuadmin added the enhancement New feature or request label May 5, 2022
@ArrEssJay
Copy link
Contributor Author

Changes requested seemed appropriate, not pedantic. I missed the ordering in ubxtypes_get.py. Thanks for correcting.

@semuadmin
Copy link
Contributor

Hi @ArrEssJay

Purely out of interest, is your F9P actually running HPG 1.32? I've seen the documentation but I couldn't find a downloadable firmware file on the ublox site. The latest I have is 1.30.

@ArrEssJay
Copy link
Contributor Author

ArrEssJay commented May 5, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants