VM: Should allow value to be set on CREATE/Call in API

[orogvany]

After looking a bit closer at eth spec, it's perfectly valid to send amount on create/call

We should update API to allow this.

It looks like there's a bug on CALL where if you supply an amount, it doesn't seem to execute the call, just does the transfer. Will write unit test for this case.

[semuxgo]

I think the issue is the local condition check below. It's null if no value is provided

semux-core/src/main/java/org/semux/api/v2/SemuxApiImpl.java

Lines 768 to 774 in 0682972

	public Response call(String from, String to, String value, String gasPrice, String gas,
	String nonce, String data, Boolean local) {
	if (local) {
	Transaction tx = getTransaction(TransactionType.CALL, from, to, value, "0", nonce, data,
	gasPrice, gas);
	SemuxTransaction transaction = new SemuxTransaction(tx);

[orogvany]

That could be part of the problem, but I am specifying local=false, and still get odd behavior.

I can run through my tests again. My setup is as follows

Create a contract that just does a transfer of amount/to to transfer from the contract to who you choose.

Call the contract setting amount>0.
Expected: sends amount to contract, and call is run sending some amount to target.

It will send amount to target if 0 is specified as amount on call, but will not if value is specified.

[orogvany]

It could be that the internal transaction is not calling with internal=false

[semuxgo]

Fixed in the develop branch