Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vote/Unvote precompiled contracts return success even in case of failure #260

Closed
honeycrypto opened this issue Aug 28, 2019 · 2 comments
Closed

Vote/Unvote precompiled contracts return success even in case of failure #260

honeycrypto opened this issue Aug 28, 2019 · 2 comments
Labels
bug Something isn't working
Milestone
v2.1.0

Comments

@honeycrypto
Copy link
Contributor

🐛 Bug

VM call fails, but the \transaction-result still reports "code": "SUCCESS"

To reproduce

  1. Send CALL vote with amount larger than current balance
  2. Send CALL unvote to a delegate where you have 0 votes

Expected Behavior

\transaction-result must return code: FAILURE. In fact, it is out of gas.
@honeycrypto honeycrypto added the bug Something isn't working label Aug 28, 2019
@orogvany
Copy link
Collaborator

Ooo. That's no good. Prob require softfork for this. Good catch.

semuxgo pushed a commit to semuxgo/semux-core that referenced this issue Sep 2, 2019
Test: reproduce issue semuxproject#260
cb93823
semuxgo pushed a commit to semuxgo/semux-core that referenced this issue Sep 2, 2019
Test: reproduce issue semuxproject#260
10fc239
semuxgo pushed a commit to semuxgo/semux-core that referenced this issue Sep 2, 2019
Test: reproduce issue semuxproject#260
3bc1009
@semuxgo semuxgo mentioned this issue Sep 3, 2019
Merged
@semuxgo semuxgo added this to the v2.1.0 milestone Sep 4, 2019
@semuxgo
Copy link
Contributor

semuxgo commented Sep 11, 2019

Will be fixed once the VOTING_PRECOMPILED_UPGRADE softfork activates.

@semuxgo semuxgo closed this as completed Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v2.1.0
Development

No branches or pull requests
3 participants
@orogvany @honeycrypto @semuxgo