[WIP] RC3 - Raise gas limits & fix client sync #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
validators fixes issue submitted by @honeycrypto Also fix client sync, and add check to ensure that bad block is not accepted on sync for testnet.
fix submitted by @cryptokat
the threshold. If there are 10 validators, with heights of 10 20 30 40 etc 66% floored gives us taking a value of 60, whereas 66% rounded gives us sync height of 70 In one case, we have 5/10 that are sync'd higher, and in the other only 4/10 that are syncd to that height or higher. Ideally, we'd probably want the inverse, so 66% are synced higher, but I imagine there's room to allow the 66th percent to sync, so sticking with pre-existing logic for sync.
orogvany
changed the title
|
Updated with more fixes from perf testing |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix client sync, and add check to ensure that bad block is not
accepted on sync for testnet.