Re-enable HD wallet #231
Merged
Re-enable HD wallet #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
July 19, 2019 21:07
- Set the hd passphrase to empty - Use fixed schme: SLIP10, English, Mainnet - Optimize UI/UX
orogvany
approved these changes
Jul 19, 2019
|
I'd like to go with |
This was referenced Jul 20, 2019
|
I thought slip-10 was not the one trezor used. Thought they used the cardano one? |
|
Oh. Slip-10 is trez and cardano is ledger? |
|
So depends on which one we want to Target. Trez accepts pull requests, ledger is closed source? Or maybe I have backwards |
|
@orogvany Here is the reference to Trezor, https://github.com/trezor/trezor-firmware/tree/master/core/docs/coins. Would appreciate it if you can double check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Credit to @orogvany