RC: 1.5.0 Testnet - VM + HD Wallets #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still a WIP, but will create a deterministic seed and use that seed for new account creation. Still need to do: * import/export seed (BIP39?) * some cleanup in lib around exceptions * not use private repo * determine testnet/mainnet for HD keys But it's a start. Please only test in testnet.
This is a work in progress, mostly to see what changes are required to semux core to support the eth VM. These classes should eventually be removed and implement these interfaces natively. But to keep scope of work down or in central location, facade classes seemed cleaner to see what core changes are necessary.
Update transaction object to have new fields for gas Stub code/data storage do a trial transaction test There's a lot here to go over, and several TODOs marked for open questions, but still feels worthwhile, even if it ends up being throwaway.
We may want to adjust this to use separate databases, but it seems to make sense to store all account information in one row.
This allows devnet users to make API calls and test out current progress.
VM: Add API support for call/create
Remove errant faux-persistence of values
Update confusion between gasLimit and gasPrice Update transaction dialog to show results of calls Update executor to run contracts that could not be preprocessed. Various cleanup
Per PR comments. We can extract separate impl later to not require Blockchain for impl.
store code/storage individually by key to keep state clean.
gas changed to long and transactionResult changed
Also update devnet with fork chains Fix bug in deterministic rand with devnet
Remove unnecessary types
Left in place for ease of local development
orogvany
changed the title
Allow running -P src-build to skip the git flag for builds from src on releases
Inadvertant change was made to script
|
Ok, going forward with merge to release RC1 for testnet. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.