Cannot add test requests for samples/worksheets already verified or published

[garciagab]

Steps to reproduce

Current behavior

Expected behavior

Screenshot (optional)

[xispa]

Hi @garciagb , thanks for your contribution!. Please note this issue is not related with senaite.impress, rather with senaite.core, so I've moved it the issue here, in senaite.core's issue tracker: https://github.com/senaite/senaite.core/issues

By default, system does not allow to add or modify tests from Analysis Requests that are in "verified" or "published" status. These states are basically end points in the Analysis Request workflow. You have different options here:

• Invalidate the Analysis Request: when an Analysis Request is invalidated, the system automatically generates a "copy" and transitions this copy to "received" status. This "copy"n (retest) has same analyses and results previously set in the invalidated Analysis Request. Since the retest is in "received" status, the system allows you to manage its analyses (add/remove tests). If the Analysis Request is invalidated after it was "published", the system will automatically send an email notification to the client contact, stating that the Analysis Request has been invalidated and therefore, the results report is no longer valid.

• Secondary Analysis Request: You have the option to keep the previous Analysis Request valid, but generate a Secondary Analysis Request with additional tests. Go to Analysis Request Add form, choose the same Sample as the previous Analysis Request in field "Sample".

• Copy to new: There is the option to create a new Analysis Request without invalidating the previous one, but keeping exactly the same tests and sample information as the primary. Go in the Analysis Requests listing, choose the Analysis Request you want to copy and press the "Copy to new" button. The AR Add form will be displayed with same values as the primary one.

• Customize Analysis Request workflow. This requires coding skills.

NB: Please try to stick to the sections the issue template provides when creating issues, it will make reviewer's live easier!

[garciagab]

Invalidate the Analysis Request: Error

Secondary Analysis Request: Error

Copy to new:
Created a new AR number with no link to the old AR number

[xispa]

The Traceback you get when creating a retest and the error when you try to create a secondary AR are because of the same reason. The ID generated for the new AR (secondary or retest) crashes with an already existing ID. I think the reason is because there is no separator between the sample ID and the "request" part: 000639R0 instead of 000639-R0.

Basically, the system tries to keep the same ID as the invalidated or primary Analysis Request, but increase the digit of the last part (the suffix) in one unit. Since there is no "separation" character explicitly set, the system is unable to recognize the last part and tries with the same ID. But the ID already exists, so the system cannot create this new entity and the error is rised.

Although we could add an hyphen in the ID between the sample id and the request number, not sure if this is a good solution given the fact you have Analysis Requests already created. Please confirm. Another solution that wouldn't require any change in your current IDs configuration, would be to make ID Server to support fixed-length parts in IDs too, at least for these two specific cases (secondary + retest): the system would look for fixed-length parts instead of specific char when splitting the ID.

I've assigned the issue to myself.

[garciagab]

Can we change the R0 to R1 so we have
000639R0
as the original
and 000639R1
for these two specific cases (secondary + retest)

[garciagab]

[xispa]

Thanks @garciagab , opened an issue for this specific "Advanced..." issue here:
#1219

Regarding the AR numbering: your "primary" AR already ends with "R0". Indeed, the rest of ARs generated from the primary as the source (e.g. retests or secondary) should follow the criteria "R1", "R2", etc.

[garciagab]

R1 , R2 is ok for me.

[xispa]

Related: #1229

[grulisco]

@xispa two questions to your initial comment:

• Secondary Analysis Request: You have the option to keep the previous Analysis Request valid, but generate a Secondary Analysis Request with additional tests. Go to Analysis Request Add form, choose the same Sample as the previous Analysis Request in field "Sample".

In current master (pre1.3) the field "Sample" is lost, so this option is not available. Is it planned to reintroduce this field?

• Copy to new: There is the option to create a new Analysis Request without invalidating the previous one, but keeping exactly the same tests and sample information as the primary. Go in the Analysis Requests listing, choose the Analysis Request you want to copy and press the "Copy to new" button. The AR Add form will be displayed with same values as the primary one.

This kind of copy will not keep old sample received date, or does it?

[xispa]

Hi @grulisco

In current master (pre1.3) the field "Sample" is lost, so this option is not available. Is it planned to reintroduce this field?

Yes, and atm we believe we have the new code base stable enough to add this feature without undesired effects. In fact, secondary sample (along with some sporadic bugs that are reported here for 1.3) is the last remaining thing before making 1.3 public. Our idea is to have it ready for testing within the following days.

This kind of copy will not keep old sample received date, or does it?

No, this kind of copy does not copy values of fields somehow related with transitions. So, no it does not keep old sample received date.

[grulisco]

Hi @xispa:
I wouldl gladly test secondary sample machinery as soon as it is available.
Normal copy sample: At least received date is editable after copying...

[xispa]

@grulisco #1284 🥇

[xispa]

Fixed in 1.3 See #1284 and #1219

[grulisco]

👍