Unable to add Analysis Services

[dninet]

Description

I'm trying to add Analysis Services but an error keeps popping up when I try to save it.

Reproduction guide

Lims Setup -> Analysis Services -> + Add

Fill out all required fields and click Save

Observed behaviour

A message appears with

Info
Changes saved.

and a traceback as seen below

Contrary to the message, the service is not saved.

Expected behaviour

Well.... a new analysis service...

Versions

• OS: Ubuntu Linux

• senaite.core: 1.3.1

Traceback

We’re sorry, but there seems to be an error…

Here is the full error message:

Display traceback as text

Traceback (innermost last):

• Module ZPublisher.Publish, line 138, in publish
• Module ZPublisher.mapply, line 77, in mapply
• Module ZPublisher.Publish, line 48, in call_object
• Module Products.CMFPlone.FactoryTool, line 478, in __call__
• Module ZPublisher.mapply, line 77, in mapply
• Module ZPublisher.Publish, line 48, in call_object
• Module Products.CMFFormController.FSControllerPageTemplate, line 91, in __call__
• Module Products.CMFFormController.BaseControllerPageTemplate, line 29, in _call
• Module Products.CMFFormController.ControllerBase, line 232, in getNext
• Module Products.CMFFormController.Actions.TraverseTo, line 38, in __call__
• Module ZPublisher.mapply, line 77, in mapply
• Module ZPublisher.Publish, line 48, in call_object
• Module Products.CMFFormController.FSControllerPythonScript, line 105, in __call__
• Module Products.CMFFormController.Script, line 145, in __call__
• Module Products.CMFCore.FSPythonScript, line 127, in __call__
• Module Shared.DC.Scripts.Bindings, line 322, in __call__
• Module Shared.DC.Scripts.Bindings, line 359, in _bindAndExec
• Module Products.PythonScripts.PythonScript, line 344, in _exec
• Module script, line 1, in content_edit <FSControllerPythonScript at /senaite/bika_setup/bika_analysisservices/portal_factory/AnalysisService/analysisservice.2019-08-02.1489681382/content_edit> Line 1
• Module Products.CMFCore.FSPythonScript, line 127, in __call__
• Module Shared.DC.Scripts.Bindings, line 322, in __call__
• Module Shared.DC.Scripts.Bindings, line 359, in _bindAndExec
• Module Products.PythonScripts.PythonScript, line 344, in _exec
• Module script, line 12, in content_edit_impl <FSPythonScript at /senaite/bika_setup/bika_analysisservices/portal_factory/AnalysisService/analysisservice.2019-08-02.1489681382/content_edit_impl> Line 12
• Module Products.Archetypes.BaseObject, line 633, in processForm
• Module Products.Archetypes.BaseObject, line 626, in _processForm __traceback_info__: (<AnalysisService at /senaite/bika_setup/bika_analysisservices/analysisservice.2019-08-02.1489681382>, <Field DuplicateVariation(fixedpoint:rw)>, <bound method AnalysisService.setDuplicateVariation of <AnalysisService at /senaite/bika_setup/bika_analysisservices/analysisservice.2019-08-02.1489681382>>)
• Module Products.Archetypes.CatalogMultiplex, line 118, in reindexObject
• Module Products.CMFPlone.CatalogTool, line 349, in catalog_object
• Module Products.ZCatalog.ZCatalog, line 476, in catalog_object
• Module Products.ZCatalog.Catalog, line 353, in catalogObject
• Module Products.ZCTextIndex.ZCTextIndex, line 184, in index_object
• Module Products.Archetypes.BaseObject, line 526, in SearchableText
• Module Products.Archetypes.BaseObject, line 526, in
• Module Products.Archetypes.utils, line 568, in getValue

TypeError: DisplayList keys must be strings or ints, got <type 'dict'>

[dninet]

Additional behaviour: when Identifiers is left empty, the Analysis Service is added successfully.

[min2great]

I am also facing the same issue. This issue seems to be with the Identifiers as for any class which implements IHaveIdentifiers interface, the user comes across the same error while saving.

[ramonski]

Thanks for reporting, we are going to remove the Identifiers from senaite.core in version 1.3.2.

[min2great]

You are welcome. But, it is a nice feature. It is really useful in situations where we want to save the IDs of the objects in the integrated system attached to LIMS object. I would strongly recommend not to remove them. Regards, Khurram.

…

On Sat, Aug 10, 2019 at 8:23 PM Ramon Bartl ***@***.***> wrote: Thanks for reporting, we are going to remove the Identifiers from senaite.core in version 1.3.2. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1416?email_source=notifications&email_token=AA23DLK5PRKT2VTZOWTHMA3QD3MP3A5CNFSM4II3IX72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4APPRI#issuecomment-520157125>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA23DLI2K4WWXQLWFCZLWWTQD3MP3ANCNFSM4II3IX7Q> .

-- Regards, Khurram.

[ramonski]

Hi Khurram,
I can understand that such a feature would be nice to have.
However, from a software development perspective, we want to shape senaite.core to provide a robust set of base functionalities, where such things can build on in separate add-ons.
In my opinion, this feature never worked properly and is not used by many labs to consider it a core functionality. Hence, we are going to remove such pieces of code which are dysfunctional, to make the system more maintainable and upgradable.
I hope you can understand that we need to make such strict decisions to get forward, otherwise we are in 20 years still on Plone 4 and Python 2.x.

[min2great]

Hi Ramon, Yeah ... you are right in this perspective ... It means IDontHaveIdentifiers ..... Thanks for your time. Khurram.

…

On Sun, Aug 11, 2019 at 1:20 AM Ramon Bartl ***@***.***> wrote: Hi Khurram, I can understand that such a feature would be nice to have. However, from a software development perspective, we want to shape senaite.core to provide a robust set of base functionalities, where such things can build on in separate add-ons. In my opinion, this feature never worked properly and is not used by many labs to consider it a core functionality. Hence, we are going to remove such pieces of code which are dysfunctional, to make the system more maintainable and upgradable. I hope you can understand that we need to make such strict decisions to get forward, otherwise we are in 20 years still on Plone 4 and Python 2.x. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1416?email_source=notifications&email_token=AA23DLJGX4JFAQIRGTXYUMDQD4PJZA5CNFSM4II3IX72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4AULKY#issuecomment-520177067>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA23DLLUOOMLTBJKZJUSTW3QD4PJZANCNFSM4II3IX7Q> .

-- Regards, Khurram.

[ramonski]

Hi Khurram,
it is always possible to contribute to the Senaite Project with a fixture for this feature, or to support it by ordering such a development from one of the service providers.
In both cases we would reconsider holding such a feature in the core.
Best regards, Ramon

[alexanderstrand]

Hi, I'm having the same issue, but cannot leave Identifiers empty as it is a required field. Is there another workaround?

Edit: Turns out it only appeared to be required by the form but was able to leave it blank. Thanks!

[min2great]

Hi. You can leave identifiers empty! It is not a required field.

…

On Wed, Aug 21, 2019 at 7:43 PM alexanderstrand ***@***.***> wrote: Hi, I'm having the same issue, but cannot leave Identifiers empty as it is a required field. Is there another workaround? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1416?email_source=notifications&email_token=AA23DLLGUCVOZKVYJ2V3UVTQFVH7RA5CNFSM4II3IX72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4Z44EY#issuecomment-523488787>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA23DLP4EASICWITUREV4JLQFVH7RANCNFSM4II3IX7Q> .

-- Regards, Khurram.

[nascimf]

@min2great Hi, I can leave identifiers empty.

When I make this, when I do this, it tells me that I must fill in that field. How you do it?
Thanks.

[min2great]

Hi, Since you have entered 'Color' in Identifier Type, its giving error. Kindly empty this field; i.e. delete the word 'Color' and then try to save it. It will save.\ Regards, Khurram.

…

On Sat, Aug 24, 2019 at 10:55 AM nascimf ***@***.***> wrote: @min2great <https://github.com/min2great> Hi, I can leave identifiers empty. [image: error identificadores] <https://user-images.githubusercontent.com/54465150/63633173-f8c0bc80-c643-11e9-9c18-23b2009b6721.png> When I make this, when I do this, it tells me that I must fill in that field. How you do it? Thanks. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1416?email_source=notifications&email_token=AA23DLIBGTUBZLXNI5RCW7LQGDEMJA5CNFSM4II3IX72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5BZOIQ#issuecomment-524523298>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA23DLPCLFRUXBTDUB25CLLQGDEMJANCNFSM4II3IX7Q> .

-- Regards, Khurram.