Fix Samples not sorted in natural order when Worksheet Template is used #1673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
When a Worksheet Template is used for the creation of a Worksheet, the system searches first for analyses based on their priority sort key ascending, which value is directly related with the Priority field from the Sample. This guarantees that analyses from samples with more priority are considered first while creating worksheets. However, once analyses are added in the worksheet, same sorting is kept.
This Pull Request makes samples from analyses to always be added in natural order when a template is used, while preserving the priority criteria when fetching the analyses from the database.
Current behavior before PR
Samples are not added in natural order in worksheets when a Worksheet Template is used
Desired behavior after PR is merged
Samples are added in natural order in worksheets when a Worksheet Template is used, regardless of their priority
--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.