Do a deepcopy of interims instead of a shallow copy #1697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a value is set to an interim with choices, the listing initially displays the value correctly because remains in `senaite.app.listing` cache, but as soon as the list is filtered or the page refreshed, the value is not displayed anymore. Listing grabs the interims from the brain directly (`getInterimFields` metadata column), but even that `set_field` endpoint from `senaite.app.listing` stores the value and reindexes the analysis object, the value of the metadata field remains unchanged. This metadata column is only used in analysis listing and we already wake-up the analysis object to grab other properties while rendering the list, so there is no advantage at all of having this metadata column. Also, the fact that interims field is stored as a dict requires special care when storing/updating this value in ZODB. Again, because of the limited use of it, the complexity it entails is not worth.
ramonski
approved these changes
Nov 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
Adheres to #1696
--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.