Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sporadic persistent changes with interims #1707

Merged
merged 1 commit into from
Dec 11, 2020
Merged

Fix sporadic persistent changes with interims #1707

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions CHANGES.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ Changelog
1.3.5 (unreleased)
------------------

**Fixed**

- #1707 Fix sporadic persistent changes with interims
- #1704 Add "User name" and "User groups" columns in Lab Contacts list
- #1704 Fix Cannot override behavior of LabContacts folder on `before_render`
- #1680 Fix Selected instrument is not assigned to analyses in Worksheet
- #1673 Fix Samples not sorted in natural order when Worksheet Template is used
Expand All @@ -24,7 +24,6 @@ Changelog

**Added**

- #1704 Add "User name" and "User groups" columns in Lab Contacts list
- #1612 Add Client sample ID to worksheet template printview
- #1609 Support result options entry for interim values
- #1598 Added "modified" index in Sample's (AnalysisRequest) catalog
Expand Down
3 changes: 2 additions & 1 deletion bika/lims/browser/analyses/view.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
import json
from collections import OrderedDict
from copy import copy
from copy import deepcopy

from DateTime import DateTime
from Products.Archetypes.config import REFERENCE_CATALOG
Expand Down Expand Up @@ -810,7 +811,7 @@ def _folder_item_calculation(self, analysis_brain, item):
interim_fields = analysis_brain.getInterimFields or list()

# Copy to prevent to avoid persistent changes
interim_fields = copy(interim_fields)
interim_fields = deepcopy(interim_fields)

for interim_field in interim_fields:
interim_keyword = interim_field.get('keyword', '')
Expand Down