Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the polyfill for the cmp builtin function #1742

Merged
merged 1 commit into from
Jan 23, 2021
Merged

Use the polyfill for the cmp builtin function #1742

merged 1 commit into from
Jan 23, 2021

Conversation

xispa
Copy link
Member

@xispa xispa commented Jan 23, 2021

Description of the issue/feature this PR addresses

This Pull Request ensures all cmp calls use the polyfill function from senaite.core.p3compat

--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.

@xispa xispa requested a review from ramonski January 23, 2021 17:38
@ramonski ramonski merged commit 6fe0d24 into 2.x Jan 23, 2021
@ramonski ramonski deleted the polyfill-comp branch January 23, 2021 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramonski ramonski ramonski approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xispa @ramonski