Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop usage of portal_catalog tool #2368

Merged
merged 36 commits into from Sep 1, 2023
Merged

Drop usage of portal_catalog tool #2368

merged 36 commits into from Sep 1, 2023

Conversation

ramonski
Copy link
Contributor

@ramonski ramonski commented Aug 30, 2023

Description of the issue/feature this PR addresses

☝️ NOTE: Please merge #2367 first!

This PR removes all remaining references where catalog searches were performed by portal_catalog

Furthermore, this PR patches the PortalCatalogProcessor utility to avoid indexing of all contents in portal_catalog. This improves the performance done in #2359 further

Current behavior before PR

portal_catalog tool was used in several places

Desired behavior after PR is merged

Use either one of the special catalogs or fall back to use uid_catalog

--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.

@ramonski ramonski added the Cleanup 🧹 Code cleanup and refactoring label Aug 30, 2023
Copy link
Member

@xispa xispa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cleanup 🧹 Code cleanup and refactoring Improvement 🔧
Development

Successfully merging this pull request may close these issues.

None yet

2 participants