Fix hanging sampletype listing view in setup #2421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramonski
changed the title
xispa
approved these changes
Nov 12, 2023
xispa
deleted the
remove-samplepoint-backrefs-from-sampletype-listing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
This PR removes the column "SamplePoints" from the Sample Types Listing to avoid long loading times without any value.
Current behavior before PR
Samplepoint backrefs from the listed sample types are filtered by the path of the setup context. This results in very long loading times when many client based sample points are used.
Desired behavior after PR is merged
The whole column for the sample points is removed, because it does not add a real value to the listing.
--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.