This repository has been archived by the owner on Jan 16, 2024. It is now read-only.
Fix sporadical errors when contacts do not have a valid email address #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
User can set invalid email addresses for Patient, Doctor and other types that inherit from Person content type. This leads to sporadic errors in views or templates that expect valid email address format.
Merge senaite/senaite.core#1542 first
Current behavior before PR
User can assign invalid email addresses in "Email address" field from contacts
Desired behavior after PR is merged
User cannot assign invalid email addresses in "Email address" field from contacts
--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.