Revert "when session.save error should return error"

This reverts commit 437f21a.
senchalabs · Mar 26, 2013 · 3edc728 · 3edc728
1 parent 1da7800
commit 3edc728
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 40 deletions.
diff --git a/lib/middleware/session.js b/lib/middleware/session.js
@@ -277,11 +277,7 @@ function session(options){
       if (!req.session) return res.end(data, encoding);
       debug('saving');
       req.session.resetMaxAge();
-      req.session.save(function(err){
-        if (err) {
-          next(err);
-          return;
-        }
+      req.session.save(function(){
         debug('saved');
         res.end(data, encoding);
       });

diff --git a/test/session.js b/test/session.js
@@ -540,41 +540,6 @@ describe('connect.session()', function(){
         });
       });
     })
-
-    describe('when session.save error', function () {
-
-      var session = require('../lib/middleware/session');
-
-      var old = session.Session.prototype.save;
-
-      before(function () {
-        session.Session.prototype.save = function (fn) {
-          fn && fn(new Error('Mock save error.'));
-        };
-      });
-
-      after(function () {
-        session.Session.prototype.save = old;
-      });
 
-      it('should return error', function (done) {
-        var app = connect()
-        .use(connect.cookieParser('keyboard cat'))
-        .use(connect.session())
-        .use(function(req, res, next){
-          req.session.count = req.session.count || 0;
-          req.session.count++;
-          res.end(req.session.count.toString());
-        });
-
-        app.request()
-        .get('/')
-        .end(function(res){
-          res.body.toString().should.include('Mock save error.');
-          done();
-        });
-      });
-    });
-
   })
 })