Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

directory() middleware does not escape # #872

Closed
ghost opened this issue Aug 21, 2013 · 2 comments · Fixed by #917
Closed

directory() middleware does not escape # #872

ghost opened this issue Aug 21, 2013 · 2 comments · Fixed by #917

Comments

@ghost
Copy link

ghost commented Aug 21, 2013

It's impossible to enter directories or open files whose name starts with a #

@jonathanong
Copy link
Contributor

are you trying to access this from the browser? the browser doesn't even send the hash portion of the URL, so you'll have it escape it yourself.

@dougwilson
Copy link
Contributor

I believe he means that if there is a directory on the server named #blah the URL to open that directory when looking at the parent directory includes a literal #, and so the client doesn't send the # and everything after it.

<a href="/dir/#child>#child</a>

The browser will just request /dir/ because of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants