Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not require that all new patches break tests #28

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Do not require that all new patches break tests #28

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 1 addition & 2 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ Before we can accept any contributions, you need to sign [Contributor License Ag

Make sure that your code passes [JSLint](http://jslint.com) checks.

Make sure your patch does break existing tests (open <code>test/index.html</code> in a web browser).
Make sure your patch does not break existing tests (open <code>test/index.html</code> in a web browser).

If you add a new feature, create a new test associated with that. Feature or enhancement pull request without a corresponding test will **not** be merged.

Expand All @@ -21,4 +21,3 @@ If you add a new feature, create a new test associated with that. Feature or enh
For the actual contribution, please use [Github pull request](http://help.github.com/pull-requests/) workflow.

Please do not create a pull request for multiple unrelated commits. It is strongly recommended to create a topic branch and make the commits as atomic as possible for the merge. This makes it easy to review all the changes.