Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CachableLookup preventing Jest from exiting #2

Closed
drewish opened this issue Apr 15, 2022 · 1 comment
Closed

CachableLookup preventing Jest from exiting #2

drewish opened this issue Apr 15, 2022 · 1 comment

Comments

@drewish
Copy link

drewish commented Apr 15, 2022

I'm not sure if this or CachableLookup is the right place to report it, but it appears a dependency of this module is preventing Jest from shutting down after running tests. When run with the --detectOpenHandles option I'm seeing:

Jest has detected the following 1 open handle potentially keeping Jest from exiting:

  ●  DNSCHANNEL

      at new CacheableLookup (../node_modules/cacheable-lookup/source/index.js:91:14)
      at new Request (../node_modules/amply.js/lib/request.js:64:21)
      at new Client (../node_modules/amply.js/lib/client.js:9:20)
      at Object.<anonymous> (../node_modules/amply.js/index.js:4:18)

I'd opened szmarczak/cacheable-lookup#58 to see if they could help but the error goes away when I comment out these two lines:

amply-js/lib/request.js

Lines 64 to 65 in 3d726e3

this.dnsCache = new cacheableLookup;
this.dnsCache.install(this.httpsAgent);

I'll try downgrading to the 0.0.2-rc.8 release and see if that addresses it.

@drewish
Copy link
Author

drewish commented Apr 15, 2022

Maybe the solution is to just upgrade Jest? jestjs/jest#11470 Seems like they no longer think this is a problem.

@drewish drewish closed this as completed Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant