feat: add scrollBehavior option to Channel #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sravan-s
approved these changes
Jul 6, 2023
|
Semgrep found 1
Risk: webpack 5.x before 5.76.0 is vulnerable to Improper Access Control due to ImportParserPlugin.js mishandling the magic comment feature. Due to this, webpack does not avoid cross-realm object access and an attacker who controls a property of an untrusted object can obtain access to the real global object. Fix: Upgrade this library to at least version 5.76.0 at sendbird-uikit-react/samples/typescript_sample/package-lock.json:16391. Reference(s): GHSA-hc6q-2mpp-qw7j, CVE-2023-28154 Ignore this finding from ssc-37ae9e0a-cbf0-4910-8f73-04f2275899a6. |
This was referenced Jul 6, 2023
Merged
AhyoungRyu
added a commit
that referenced
this pull request
Jul 7, 2023
�Added a missing type `scrollBehavior` added by #676 to d ts file.
AhyoungRyu
added a commit
that referenced
this pull request
Jul 7, 2023
## [v3.6.3] (July 6 2023) ### Feat: * Add new scrollBehavior prop to Channel (#676) The default option is set to "auto," preserving the existing scroll behavior. Possible to set smooth for smooth scroll effect. ### Fixes: * Move message list scroll when the last message is edited (#674) Added optional parameters to moveScroll to scroll only when the last message reaches the bottom. Scroll is now moved only when the updatedAt property of the last message is changed. * Add missing `UIKitConfig` to type definition (#677) Reported by [GitHub PR #650](#650 (comment)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses one of request in https://sendbird.atlassian.net/browse/AC-12
Added
scrollBehaviorprop to allow user to pass"smooth"option on scroll event via Channel component(provider).But I set the default option to
autowhich is an initial value of this CSS property not to change the existing behavior.You can see the difference of the each values of
scrollBahaviorin the mozilla docs site :)