Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this is very interesting data structure! Thank you for the detailed explanation and implementation!
I found an issue that might case access to an unwanted position (either out-of-bounds or different element) of the underlying array when
RotatedArraySet
is used with a large number of elements (somewhere around 10^8 to 10^9). Maybe it'd be better to select other data structures that has logarithmic performance at that large scale, but here's a patch anyway.