Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update the Client file documentation #111

Merged
merged 3 commits into from
Feb 19, 2020

Conversation

vinifarias
Copy link
Contributor

Short description of what this PR does:

  • Adds and corrects the Client class methods documentation.

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 27, 2018
@SendGridDX
Copy link

SendGridDX commented Oct 27, 2018

CLA assistant check
All committers have signed the CLA.

@vinifarias
Copy link
Contributor Author

vinifarias commented Oct 27, 2018

Hi guys, I'm participating in hacktoberfest, so please mark this pull request with the hacktoberfest and difficulty: easy labels :)

@codecov
Copy link

codecov bot commented Feb 19, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@12d28b7). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #111   +/-   ##
=========================================
  Coverage          ?   46.47%           
  Complexity        ?       36           
=========================================
  Files             ?        5           
  Lines             ?      213           
  Branches          ?       16           
=========================================
  Hits              ?       99           
  Misses            ?      110           
  Partials          ?        4
Impacted Files Coverage Δ Complexity Δ
src/main/java/com/sendgrid/Client.java 30.28% <ø> (ø) 10 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12d28b7...6e1befc. Read the comment docs.

@thinkingserious thinkingserious merged commit 98190c4 into sendgrid:master Feb 19, 2020
@thinkingserious
Copy link
Contributor

Hello @vinifarias,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@thinkingserious thinkingserious changed the title Update the Client file documentation chore: Update the Client file documentation Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants