Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Response Charset to UTF-8. #7

Merged
merged 3 commits into from
Aug 9, 2016
Merged

Conversation

kikutaro
Copy link
Contributor

patch for issue #6

@thinkingserious thinkingserious added status: cla signed type: community enhancement feature request not on Twilio's roadmap labels Jul 11, 2016
@thinkingserious
Copy link
Contributor

This is awesome, thanks! We have this on our backlog to be merged.

Also, please email us at dx@sendgrid.com with your T-shirt size and mailing address so we can send you some swag :)

@kikutaro
Copy link
Contributor Author

Hi @thinkingserious , I sent email :) Thanks!

@thinkingserious
Copy link
Contributor

Hello @kikutaro,

I ran into an issue when trying to run the Example. On this line, I get:

Exception in thread "main" java.lang.IllegalArgumentException: Entity may not be null
    at org.apache.http.util.Args.notNull(Args.java:54)
    at org.apache.http.util.EntityUtils.toString(EntityUtils.java:214)
    at com.sendgrid.Client.getResponse(Client.java:138)
    at com.sendgrid.Client.delete(Client.java:344)
    at com.sendgrid.Client.api(Client.java:375)
    at Example.main(Example.java:109)

I'm thinking we just need a null check before we call EntityUtils.

@kikutaro
Copy link
Contributor Author

kikutaro commented Aug 2, 2016

Oh, okay. Sorry for that I didn't check the example. I only focus test code.
I'll check the case soon. Thanks.

@kikutaro
Copy link
Contributor Author

kikutaro commented Aug 4, 2016

Hi @thinkingserious,

I added null check. Thanks.

@thinkingserious
Copy link
Contributor

Awesome, thanks!

@thinkingserious
Copy link
Contributor

@kikutaro,

Could you please update your branch against the latest version? https://github.com/sendgrid/java-http-client/releases/tag/v2.3.3

I'd like to merge your branch next. Thanks!

@kikutaro
Copy link
Contributor Author

kikutaro commented Aug 9, 2016

I tried it. Sorry that I'm pretty new this pattern merge for me...
If you have any issue on my pull request, please let me know. Thanks.

@thinkingserious thinkingserious merged commit 7e99ce6 into sendgrid:master Aug 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: community enhancement feature request not on Twilio's roadmap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants