Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

converted README and version as file #93

Merged
merged 6 commits into from
Oct 22, 2018
Merged

converted README and version as file #93

merged 6 commits into from
Oct 22, 2018

Conversation

StrikerRUS
Copy link
Contributor

@StrikerRUS StrikerRUS commented Oct 4, 2018

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • [n/a] I have added necessary documentation about the functionality in the appropriate .md file
  • [n/a] I have added in line documentation to the code I modified

Short description of what this PR does:

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 4, 2018
@SendGridDX
Copy link

SendGridDX commented Oct 4, 2018

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Oct 4, 2018

Codecov Report

Merging #93 into master will increase coverage by 0.11%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #93      +/-   ##
==========================================
+ Coverage   91.34%   91.46%   +0.11%     
==========================================
  Files           6        6              
  Lines         289      293       +4     
==========================================
+ Hits          264      268       +4     
  Misses         25       25
Impacted Files Coverage Δ
tests/test_repofiles.py 100% <ø> (ø) ⬆️
python_http_client/__init__.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9196b9f...4f8466a. Read the comment docs.

@StrikerRUS
Copy link
Contributor Author

StrikerRUS commented Oct 4, 2018

All tests on Travis are green, but the status on GitHub hasn't been updated. If it's an issue, then closing and reopening the PR can help.
Not actual anymore.

@thinkingserious thinkingserious added type: community enhancement feature request not on Twilio's roadmap difficulty: medium fix is medium in difficulty hacktoberfest labels Oct 9, 2018
@thinkingserious
Copy link
Contributor

Hello @StrikerRUS,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@thinkingserious
Copy link
Contributor

@StrikerRUS
Copy link
Contributor Author

@thinkingserious Thanks a lot for the kind words!

Sure, I'll create PRs for other repos.
BTW, the similar PR for sendgrid-python has been already created: sendgrid/sendgrid-python#634.

@StrikerRUS
Copy link
Contributor Author

@misterdorm misterdorm added status: work in progress Twilio or the community is in the process of implementing and removed status: code review request requesting a community code review or review from Twilio labels Oct 19, 2018
@thinkingserious thinkingserious merged commit c943981 into sendgrid:master Oct 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: medium fix is medium in difficulty status: work in progress Twilio or the community is in the process of implementing type: community enhancement feature request not on Twilio's roadmap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants