-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
converted README and version as file #93
Conversation
Codecov Report
@@ Coverage Diff @@
## master #93 +/- ##
==========================================
+ Coverage 91.34% 91.46% +0.11%
==========================================
Files 6 6
Lines 289 293 +4
==========================================
+ Hits 264 268 +4
Misses 25 25
Continue to review full report at Codecov.
|
|
Hello @StrikerRUS, |
This is awesome @StrikerRUS! Would you mind doing the same for our other Python repos? https://github.com/sendgrid/sendgrid-python Thanks! With Best Regards, Elmer |
@thinkingserious Thanks a lot for the kind words! Sure, I'll create PRs for other repos. |
@thinkingserious Here're updates about PRs. Please take a look.
|
Checklist
Short description of what this PR does:
__version__
attribute to the package. This attribute is read from theVERSION.txt
file, so in the future version should be incremented only in the file (related to Implement auto-deploy to package manager #92).README.md
toREADME.rst
(appearance can be checked in this branch https://github.com/StrikerRUS/python-http-client/blob/pypi/README.rst), sosetup.cfg
andregister.py
are not needed anymore.