Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add SendWithContext function #92

Merged
merged 5 commits into from Feb 12, 2021
Merged

fix: add SendWithContext function #92

merged 5 commits into from Feb 12, 2021

Conversation

someone1
Copy link
Contributor

@someone1 someone1 commented Dec 21, 2018 •
edited

Fixes

[fixes #91]

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the development branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Adds the ability to make requests to the sendgrid API, passing in a context.Context object (for deadlines/timeouts, tracing, etc.)

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Dec 21, 2018
@SendGridDX
Copy link

SendGridDX commented Dec 21, 2018 •
edited

CLA assistant check
All committers have signed the CLA.

@someone1 someone1 force-pushed the patch-1 branch 2 times, most recently from 6e86d8e to 580572d Compare December 21, 2018 21:21
@someone1
Copy link
Contributor Author

Out of curiosity, why is this supported back to go1.6? Aren't only the last 2 versions officially supported by the go team?

@thinkingserious thinkingserious changed the base branch from master to main July 28, 2020 14:37
joshk0
joshk0 reviewed Feb 12, 2021
View reviewed changes
rest.go
@@ -6,6 +6,8 @@ import (
"io/ioutil"
"net/http"
"net/url"

"golang.org/x/net/context"
Copy link

@joshk0 joshk0 May 15, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it is 2021 now, at this point, let's use "context" and drop support for Go <= 1.7?

thinkingserious
thinkingserious approved these changes Feb 12, 2021
View reviewed changes
Copy link
Contributor

@thinkingserious thinkingserious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @someone1! 🎆

@thinkingserious thinkingserious added type: community enhancement feature request not on Twilio's roadmap and removed status: code review request requesting a community code review or review from Twilio labels Feb 12, 2021
@thinkingserious thinkingserious merged commit 50656d6 into sendgrid:main Feb 12, 2021
@thinkingserious thinkingserious changed the title Add SendWithContext function [fixes #91] fix: add SendWithContext function Mar 15, 2021
@dependabot dependabot bot mentioned this pull request Mar 16, 2021
Closed
@someone1 someone1 deleted the patch-1 branch April 7, 2021 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshk0 joshk0 joshk0 left review comments

@thinkingserious thinkingserious thinkingserious approved these changes

@denyska denyska denyska approved these changes

Assignees
No one assigned
Labels
type: community enhancement feature request not on Twilio's roadmap
Projects
None yet
Milestone
No milestone
5 participants
@someone1 @SendGridDX @thinkingserious @denyska @joshk0