Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix runtime warnings 4 #625

Closed
mbernier opened this issue Oct 31, 2017 · 1 comment
Closed

Fix runtime warnings 4 #625

mbernier opened this issue Oct 31, 2017 · 1 comment
Labels
difficulty: easy fix is easy in difficulty type: twilio enhancement feature request on Twilio's roadmap

Comments

@mbernier
Copy link
Contributor

Issue Summary

ISendGridClient.cs(9,5): warning SA1208: Using directive for 'System.Collections.Generic' must appear before directive for 'Helpers.Mail' [/home/travis/build/sendgrid/sendgrid-csharp/src/SendGrid/SendGrid.csproj]
ISendGridClient.cs(10,5): warning SA1208: Using directive for 'System.Net.Http' must appear before directive for 'Helpers.Mail' [/home/travis/build/sendgrid/sendgrid-csharp/src/SendGrid/SendGrid.csproj]
ISendGridClient.cs(11,5): warning SA1208: Using directive for 'System.Net.Http.Headers' must appear before directive for 'Helpers.Mail' [/home/travis/build/sendgrid/sendgrid-csharp/src/SendGrid/SendGrid.csproj]
ISendGridClient.cs(12,5): warning SA1208: Using directive for 'System.Threading' must appear before directive for 'Helpers.Mail' [/home/travis/build/sendgrid/sendgrid-csharp/src/SendGrid/SendGrid.csproj]
ISendGridClient.cs(13,5): warning SA1208: Using directive for 'System.Threading.Tasks' must appear before directive for 'Helpers.Mail' [/home/travis/build/sendgrid/sendgrid-csharp/src/SendGrid/SendGrid.csproj]
Response.cs(9,5): warning SA1208: Using directive for 'System.Collections.Generic' must appear before directive for 'Newtonsoft.Json' [/home/travis/build/sendgrid/sendgrid-csharp/src/SendGrid/SendGrid.csproj]
Response.cs(10,5): warning SA1208: Using directive for 'System.Linq' must appear before directive for 'Newtonsoft.Json' [/home/travis/build/sendgrid/sendgrid-csharp/src/SendGrid/SendGrid.csproj]
Response.cs(11,5): warning SA1208: Using directive for 'System.Net' must appear before directive for 'Newtonsoft.Json' [/home/travis/build/sendgrid/sendgrid-csharp/src/SendGrid/SendGrid.csproj]
Response.cs(12,5): warning SA1208: Using directive for 'System.Net.Http' must appear before directive for 'Newtonsoft.Json' [/home/travis/build/sendgrid/sendgrid-csharp/src/SendGrid/SendGrid.csproj]
Response.cs(13,5): warning SA1208: Using directive for 'System.Net.Http.Headers' must appear before directive for 'Newtonsoft.Json' [/home/travis/build/sendgrid/sendgrid-csharp/src/SendGrid/SendGrid.csproj]
SendGridClientOptions.cs(1,1): warning SA1633: The file header is missing or not located at the top of the file. [/home/travis/build/sendgrid/sendgrid-csharp/src/SendGrid/SendGrid.csproj]
SendGridClient.cs(10,5): warning SA1208: Using directive for 'System' must appear before directive for 'Newtonsoft.Json' [/home/travis/build/sendgrid/sendgrid-csharp/src/SendGrid/SendGrid.csproj]
SendGridClient.cs(11,5): warning SA1208: Using directive for 'System.Collections.Generic' must appear before directive for 'Newtonsoft.Json' [/home/travis/build/sendgrid/sendgrid-csharp/src/SendGrid/SendGrid.csproj]
SendGridClient.cs(12,5): warning SA1208: Using directive for 'System.Net' must appear before directive for 'Newtonsoft.Json' [/home/travis/build/sendgrid/sendgrid-csharp/src/SendGrid/SendGrid.csproj]
SendGridClient.cs(13,5): warning SA1208: Using directive for 'System.Net.Http' must appear before directive for 'Newtonsoft.Json' [/home/travis/build/sendgrid/sendgrid-csharp/src/SendGrid/SendGrid.csproj]
SendGridClient.cs(14,5): warning SA1208: Using directive for 'System.Net.Http.Headers' must appear before directive for 'Newtonsoft.Json' [/home/travis/build/sendgrid/sendgrid-csharp/src/SendGrid/SendGrid.csproj]
SendGridClient.cs(15,5): warning SA1208: Using directive for 'System.Reflection' must appear before directive for 'Newtonsoft.Json' [/home/travis/build/sendgrid/sendgrid-csharp/src/SendGrid/SendGrid.csproj]
SendGridClient.cs(16,5): warning SA1208: Using directive for 'System.Text' must appear before directive for 'Newtonsoft.Json' [/home/travis/build/sendgrid/sendgrid-csharp/src/SendGrid/SendGrid.csproj]
SendGridClient.cs(17,5): warning SA1208: Using directive for 'System.Threading' must appear before directive for 'Newtonsoft.Json' [/home/travis/build/sendgrid/sendgrid-csharp/src/SendGrid/SendGrid.csproj]
SendGridClient.cs(18,5): warning SA1208: Using directive for 'System.Threading.Tasks' must appear before directive for 'Newtonsoft.Json' [/home/travis/build/sendgrid/sendgrid-csharp/src/SendGrid/SendGrid.csproj]
obj/Release/net452/SendGrid.AssemblyInfo.cs(1,1): warning SA1633: The file header XML is invalid. [/home/travis/build/sendgrid/sendgrid-csharp/src/SendGrid/SendGrid.csproj]
SendGridClient.cs(46,28): warning SA1201: A field should not follow a property [/home/travis/build/sendgrid/sendgrid-csharp/src/SendGrid/SendGrid.csproj]
SendGridClient.cs(203,21): warning SA1201: A enum should not follow a method [/home/travis/build/sendgrid/sendgrid-csharp/src/SendGrid/SendGrid.csproj]
SendGridClient.cs(121,16): warning SA1202: 'public' members must come before 'internal' members [/home/travis/build/sendgrid/sendgrid-csharp/src/SendGrid/SendGrid.csproj]
SendGridClientOptions.cs(19,13): warning SA1101: Prefix local calls with this [/home/travis/build/sendgrid/sendgrid-csharp/src/SendGrid/SendGrid.csproj]
SendGridClientOptions.cs(20,13): warning SA1101: Prefix local calls with this [/home/travis/build/sendgrid/sendgrid-csharp/src/SendGrid/SendGrid.csproj]
SendGridClientOptions.cs(21,13): warning SA1101: Prefix local calls with this [/home/travis/build/sendgrid/sendgrid-csharp/src/SendGrid/SendGrid.csproj]
Helpers/Mail/SendGridMessage.cs(146,13): warning SA1101: Prefix local calls with this [/home/travis/build/sendgrid/sendgrid-csharp/src/SendGrid/SendGrid.csproj]
Helpers/Mail/SendGridMessage.cs(144,17): warning SA1503: Braces must not be omitted [/home/travis/build/sendgrid/sendgrid-csharp/src/SendGrid/SendGrid.csproj]
Reliability/RetryDelegatingHandler.cs(46,60): warning SA1600: Elements must be documented [/home/travis/build/sendgrid/sendgrid-csharp/src/SendGrid/SendGrid.csproj]
Helpers/Mail/SendGridMessage.cs(265,13): warning SA1101: Prefix local calls with this [/home/travis/build/sendgrid/sendgrid-csharp/src/SendGrid/SendGrid.csproj]
Helpers/Mail/SendGridMessage.cs(263,17): warning SA1503: Braces must not be omitted [/home/travis/build/sendgrid/sendgrid-csharp/src/SendGrid/SendGrid.csproj]
Helpers/Mail/SendGridMessage.cs(384,13): warning SA1101: Prefix local calls with this [/home/travis/build/sendgrid/sendgrid-csharp/src/SendGrid/SendGrid.csproj]
Helpers/Mail/SendGridMessage.cs(382,17): warning SA1503: Braces must not be omitted [/home/travis/build/sendgrid/sendgrid-csharp/src/SendGrid/SendGrid.csproj]
Helpers/Mail/SendGridMessage.cs(910,13): warning SA1101: Prefix local calls with this [/home/travis/build/sendgrid/sendgrid-csharp/src/SendGrid/SendGrid.csproj]
@thinkingserious thinkingserious added status: help wanted requesting help from the community difficulty: easy fix is easy in difficulty up-for-grabs type: twilio enhancement feature request on Twilio's roadmap labels Mar 1, 2018
@danjagnow danjagnow mentioned this issue Mar 26, 2018
Merged
6 tasks
@childish-sambino
Copy link
Contributor

Fixed by #682

@childish-sambino childish-sambino removed hacktoberfest status: help wanted requesting help from the community labels Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty: easy fix is easy in difficulty type: twilio enhancement feature request on Twilio's roadmap
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@thinkingserious @mbernier @childish-sambino