Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Ensuring default serialization settings behave correctly #1008

Merged
merged 1 commit into from
Jun 5, 2020
Merged

test: Ensuring default serialization settings behave correctly #1008

merged 1 commit into from
Jun 5, 2020

Conversation

duncanchung
Copy link
Contributor

Extending the test to ensure default serialization isn't broken.

Addressing:
#938 (comment)

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the master branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

@duncanchung
Ensuring default serialization settings behave correctly
c839771 
Extending test to ensure default serialization isn't broken.

Addressing:
#938 (comment)
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Jun 2, 2020
thinkingserious
thinkingserious approved these changes Jun 5, 2020
View reviewed changes
Copy link
Contributor

@thinkingserious thinkingserious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@thinkingserious thinkingserious merged commit bbafa66 into sendgrid:master Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thinkingserious thinkingserious thinkingserious approved these changes

Assignees
No one assigned
Labels
status: code review request requesting a community code review or review from Twilio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@duncanchung @thinkingserious